Linting workflow for CI #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added scripts to lint HTML and SCSS (or both!) and to run jekyll "hyde" (hah) checks. The "hyde" command is not included in the overall "lint" because it we will want to run javascript-only checks more often and possibly in ruby-free environments.
This value obviously only works for local builds, but it *does* work for those, and for CI checks, so it seems better to have than not.
Added a workflow to run lint checks on all pull requests, and tweaked the package scripts to allow skipping Ruby gem installation when no jekyll execution is planned.
|
See benwarfield-usds#1 to see the workflow actually working. |
benwarfield-usds
commented
Oct 8, 2020
| @@ -26,8 +30,11 @@ | |||
| "gulp-replace": "^1.0.0", | |||
| "gulp-sass": "^4.1.0", | |||
| "gulp-sourcemaps": "^2.6.5", | |||
| "htmllint-cli": "0.0.7", | |||
| "markdownlint-cli": "^0.24.0", | |||
There was a problem hiding this comment.
Didn't actually use this because the base distro has no markdown in it. Probably worth fixing that, and then adding some linting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
jekyll hydeon every pull requestFixed