Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeletonization in libpysal.cg #22

Open
martinfleis opened this issue Jul 24, 2024 · 7 comments
Open

Skeletonization in libpysal.cg #22

martinfleis opened this issue Jul 24, 2024 · 7 comments

Comments

@martinfleis
Copy link
Contributor

@jGaboardi a question mostly for you. Given the relatively generic nature of the skeletonization, do you reckon it could be merged upstream to lib?

@jGaboardi
Copy link
Collaborator

You are referring to the geometry.voronoi_skeleton() function in uscuni/simplification#95, correct?

@martinfleis
Copy link
Contributor Author

Yea

@martinfleis
Copy link
Contributor Author

In maybe a bit more generic shape.

@jGaboardi
Copy link
Collaborator

do you reckon it could be merged upstream to lib?

I think there could surely be appetite for that. Especially since it's not all that much code.

@jGaboardi
Copy link
Collaborator

Moving to sgeop since the will live there soon.

@jGaboardi jGaboardi transferred this issue from uscuni/simplification Oct 5, 2024
@jGaboardi
Copy link
Collaborator

xref #25

  • now that the geometry.voronoi_skeleton() function is quasi-matured and tested, we may want to revisit this.

@martinfleis
Copy link
Contributor Author

I'd say that this is not on top of the priority list. Eventually it would be nice but I'd try to finish the stuff that will make it into the publication before looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants