Convert the library to use Signals and reactive elements #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +11.1 kB (+28.1%) 🚨 Total Size: 50.7 kB
|
|
Awesome! :) We should optimise the new components to reduce the bundle size. Looks great overall. |
afshinm
approved these changes
Sep 11, 2024
afshinm
reviewed
Sep 11, 2024
| this: Hint, | ||
| hintElement: HTMLElement, | ||
| item: HintItem, | ||
| stepId: number |
There was a problem hiding this comment.
This is a backward incompatible change and should be announced.
afshinm
reviewed
Sep 11, 2024
|
|
||
| const root = div( | ||
| { | ||
| className: "introjs-tour", |
There was a problem hiding this comment.
would be great to colocate the classNames, too
afshinm
reviewed
Sep 11, 2024
| if (step >= this._currentStep) { | ||
| if ( | ||
| this._currentStepSignal.val === undefined || | ||
| step >= this._currentStepSignal.val |
There was a problem hiding this comment.
use this.getCurrentStep()?
afshinm
reviewed
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the entire library to use Signals and reactive elements as opposed to manually managing the DOM elements. This would help eliminate some of the existing bugs and also make the library much easier to maintain long-term.
Here is the gist of the changes: