Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utils script for feature summarize the paper #197

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

liangmaomaomao
Copy link

Thanks for opening a PR. Please read the following:

  • Base your changes on the dev branch
    • If necessary, rebase against dev before opening a pull request
  • Follow PEP 8. I currently periodically run Black against the codebase and perhaps you should, too
  • Use spaces for indentation, and ensure that all methods have a proper docstring. Please don't use Doctest
  • If at all possible, don't add dependencies
    • If it's unavoidable, ensure that the dependency is maintained, and supported
    • Ensure that you add your dependency to setup.py
  • Run the tests, and ensure that they pass. If you're adding a feature, you must add tests that exercise it
  • If your pull request is a feature, document it
  • One feature per pull request
  • If possible, squash your commits before opening a pull request, unless it makes no sense to do so
  • If in doubt, comment your code.

License of Contributed Code

Unless you explicitly state otherwise, any contribution intentionally submitted for inclusion in the work by you shall be MIT licensed, without any additional terms or conditions.
Please note that pull requests with licenses that are more restrictive than or otherwise incompatible with the MIT license will not be accepted.

@urschrei
Copy link
Owner

I don't know what this script is supposed to do as it's not documented, and it isn't linked to functionality that exists in the Pyzotero library. I suspect that it would be best to keep it as part of your own tools.

@urschrei urschrei force-pushed the dev branch 4 times, most recently from 8419300 to 8e3d550 Compare December 28, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants