Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BulkListLimit parameter #46

Closed
wants to merge 1 commit into from
Closed

Conversation

aleksandre
Copy link

Possible fix to issue #45.

@urielha
Copy link
Owner

urielha commented Aug 8, 2018

Hi,
Thanks for the PR but I preferred another approach.
you can see in this commit.

In general, it has the same purpose of your change - dropping events if reaching a limit. But here I'm using the BulkSize as the limit and let the background timer to do the actual logging.

@urielha urielha closed this Aug 8, 2018
@urielha
Copy link
Owner

urielha commented Aug 8, 2018

I will publish this in the next version - will be false by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants