-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Стольников Константин #101
base: master
Are you sure you want to change the base?
Conversation
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
some changes with whortin words
🍏 Пройден линтинг и базовые тесты |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍅
Привет! Давай будем следить за тем, чтобы инструкция !important
использовалась только в крайних случаях 😅
В 20-ом задании попробуй подумать на тему псевдокласса :nth-last-child
|
||
input:focus | ||
{ | ||
border: 3px solid #6698ff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В двух селекторах с псевдоклассами полностью переопределяется правило, задающее стили для границы в селекторе тега input
, хотя разница только в цвете этой границы. Можно в селекторах с псевдоклассами :first-child
и :focus
переназначать только border-color
background-color: #ff6; | ||
} | ||
|
||
div:nth-child(4n-1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Попробуй использовать псевдокласс :empty
|
||
div:first-child | ||
{ | ||
background-color: #ffb366; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Правило дублируется
@@ -12,7 +12,10 @@ <h1 class="global-heading"> </h1> | |||
|
|||
<main class="global-results"> | |||
<style> | |||
/* your styles here */ | |||
div:nth-child(4n + 1) > div:first-child |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Обрати внимание на псевдокласс only-of-type
|
||
ul | ||
{ | ||
list-style-type: square !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Получится ли не прибегать к !important
здесь? Подсказка: можно стилизовать псевдоэлементы, например, before
@@ -12,7 +12,11 @@ <h1 class="global-heading"> </h1> | |||
|
|||
<main class="global-results"> | |||
<style> | |||
/* your styles here */ | |||
input#checkbox:checked ~ div |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Зачем столько селекторов? Не достаточно ли указать только идентификатор или только тег?
|
||
article > div:last-child | ||
{ | ||
opacity: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Здесь можно просты выбрать все картинки, у которых нет атрибута alt
@@ -12,7 +12,15 @@ <h1 class="global-heading"> </h1> | |||
|
|||
<main class="global-results"> | |||
<style> | |||
/* your styles here */ | |||
[href*='//'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Выбери все абсолютные урлы, в которых не содержится my-site.ru
color: #ff6698; | ||
} | ||
|
||
[href*='my-site.ru'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Для my-site
давай не будем переназначать стили
/* your styles here */ | ||
[href]:visited | ||
{ | ||
color: #ffb366 !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Давай здесь везде тоже без !important
)
Повысить специфичность можно, указав в селекторе помимо атрибута ещё и класс
Первый коммит, первые тесты
Посмотреть решение