Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dev instructions #1115

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update dev instructions #1115

wants to merge 3 commits into from

Conversation

dillon
Copy link
Contributor

@dillon dillon commented Jul 28, 2023

Provides some clarity for running development on your local network

@dillon dillon requested a review from tomholford July 28, 2023 19:01
@dillon dillon changed the title Dp/update dev instructions update dev instructions Jul 28, 2023
@jalehman jalehman requested review from shawntobin and pkova and removed request for tomholford September 8, 2023 15:28
Copy link
Contributor

@shawntobin shawntobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
My only other thought is that we could mention how the roller needs to be set up again if the user runs 'npm run pilot' again, but maybe it's obvious enough

DEVELOPMENT.md Outdated

## General notes

For development over your local network, follow the instructions in the "L2 Local Environment." You can then run `npm run pilot` to boot up a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should say "follow the instructions in 'Local Development'..." instead of 'L2 Local Environment' since it looks like the header has been changed below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants