Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to OpenStudio 3.9 and Ruby 3.2.2 #155

Merged
merged 59 commits into from
Jan 27, 2025
Merged

Upgrade to OpenStudio 3.9 and Ruby 3.2.2 #155

merged 59 commits into from
Jan 27, 2025

Conversation

vtnate
Copy link
Collaborator

@vtnate vtnate commented Nov 13, 2024 •
edited
Loading

Resolves #[issue number here]

Pull Request Description

  • Update to OpenStudio 3.9
  • Necessitates an update to Ruby 3.2.2
  • Temporarily use branches of OS dependencies during testing

Checklist (Delete lines that don't apply)

  • Unit tests have been added or updated
  • Documentation has been modified appropriately
  • All ci tests pass (green)
  • An issue has been created (which will be used for the changelog)
  • This branch is up-to-date with develop

vtnate and others added 30 commits July 18, 2024 10:47
@vtnate
bump to v0.13.0
898dcb3
@vtnate
clarify ruby version, remove duplicate dependencies
a1112b6
@vtnate
use branches of UO gems
230b7d1
@vtnate
use OS3.8 in CI
6a8f6f2
@vtnate
use extension-gem branch temporarily
7128d33
@vtnate
ensure we install bundle according to gemspec & gemfile in CI
cb655d8
@vtnate
non-substantive typos
be301c4
@vtnate
remove requirement for certified because of Ruby 3
26a427a
@vtnate
remove references to certified, and make error messages visible
d55d923
@vtnate
remove test file that doesn't do anything and isn't used
0d6936f
@vtnate
use newly released patch version 0.8.1 of extension-gem
a93f56e
@tanushree04 @vtnate
update reopt ghp lcca outputs in schema
f9fdf52
@tanushree04 @vtnate
add input processing
65402b9
@tanushree04 @vtnate
add reopt api call and tests
b82439a
@tanushree04 @vtnate
update test files and code
8135b91
@tanushree04 @vtnate
make folder reopt input only when not exist, add heat pump size
f023142
@tanushree04 @vtnate
update electrical power value
5e2a34b
@tanushree04 @vtnate
update reopt api polling
f304cd8
@tanushree04 @vtnate
add test
b2eac71
@tanushree04 @vtnate
update tests
183d553
@tanushree04 @vtnate
uodate tests
2f2aa20
@tanushree04 @vtnate
remove puts statement
13ff59f
@tanushree04 @vtnate
update input reopt file
9c13427
@tanushree04 @vtnate
update reopt assumption file
1310070
@tanushree04 @vtnate
update whitespace
9177f69
@tanushree04 @vtnate
update modelica result
64999a8
@tanushree04 @vtnate
update inputs
581f2b3
@tanushree04 @vtnate
uncomment test
4a90bd6
@tanushree04 @vtnate
add feature reports
99e9615
@tanushree04 @vtnate
update test
105e3e0
@vtnate vtnate added enhancement New feature or request Clean GEMFILE before merge This uses a temporary dependency version breaking-change This update is not backward compatible labels Nov 13, 2024
@vtnate vtnate self-assigned this Nov 13, 2024
@coveralls
Copy link

coveralls commented Nov 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12997113022

Details

  • 13 of 16 (81.25%) changed or added relevant lines in 5 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 75.994%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/urbanopt/reopt/feature_report_adapter.rb 2 3 66.67%
lib/urbanopt/reopt/reopt_ghp_post_processor.rb 5 6 83.33%
lib/urbanopt/reopt/scenario_report_adapter.rb 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
lib/urbanopt/reopt/reopt_ghp_post_processor.rb 1 89.29%
lib/urbanopt/reopt/feature_report_adapter.rb 4 72.12%
Totals Coverage Status
Change from base Build 12901847585: -0.4%
Covered Lines: 994
Relevant Lines: 1308
💛 - Coveralls

vtnate and others added 4 commits December 19, 2024 12:41
@vtnate
use real OS3.9 in CI
b1a7d88
@vtnate
use extension-gem branch
20222f9
@kflemin
update dependencies
9af5f52
@vtnate
Updates to handle breaking changes from REopt v3.11 (#157)
c81d59b 
* use released versions of gems

* bump to v1.0.0

* add year to district input for ElectricLoad

* add year to ElectricLoad for GHP assumptions

* add year to ElectricLoad test assumption files

* use `v3` in ghp test api url instead of `stable`

* rubocop formatting

* remove unused variable

* less action & more assertion in 15-minute-interval test
@vtnate vtnate requested a review from kflemin January 27, 2025 19:43
@kflemin kflemin merged commit 4038888 into develop Jan 27, 2025
1 check passed
@kflemin kflemin deleted the os39 branch January 27, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kflemin kflemin kflemin approved these changes

Assignees

@vtnate vtnate

Labels
breaking-change This update is not backward compatible Clean GEMFILE before merge This uses a temporary dependency version enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtnate @coveralls @kflemin @tanushree04