Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add maskVars support from yii 2.0.16 #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Alexz29
Copy link

@Alexz29 Alexz29 commented Feb 5, 2019

No description provided.

@petrabarus
Copy link
Contributor

@Alexz29 you might want to update the composer json to lock yii version 2.0.16.

@petrabarus
Copy link
Contributor

Might want to generate the composer.lock as well.

@petrabarus
Copy link
Contributor

The build still fails, though :(

@codecov
Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #2 into master will increase coverage by 0.75%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage      75%   75.75%   +0.75%     
==========================================
  Files           1        1              
  Lines          96       99       +3     
==========================================
+ Hits           72       75       +3     
  Misses         24       24
Impacted Files Coverage Δ
src/JsonFileTarget.php 75.75% <83.33%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6e6823...22f8cef. Read the comment docs.

@petrabarus
Copy link
Contributor

@Alexz29 couple of reviews from me.

  1. I think the yii2 requirement should be >=2.0.16 instead of just 2.0.16
  2. Might want to add 7.2 and 7.3 as the travis environment.
  3. Let's squash the commits into one so the commit history will look pretty.

@Alexz29 Alexz29 force-pushed the master branch 2 times, most recently from 250eb39 to 22f8cef Compare February 6, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants