Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Live Update & fallback #597

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Add Live Update & fallback #597

merged 4 commits into from
Oct 1, 2024

Conversation

rlepinski
Copy link
Collaborator

Adds Android Live Update support and fallback for user notifications.

@rlepinski rlepinski requested a review from crow as a code owner October 1, 2024 15:57
src/types.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jyaganeh jyaganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, aside from the channel thing

context, 0, launchIntent, PendingIntent.FLAG_IMMUTABLE
)

val notification = NotificationCompat.Builder(context, "sports")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "sports" should be "emoji-example" here?

@rlepinski rlepinski merged commit d4f95d3 into main Oct 1, 2024
1 check passed
@rlepinski rlepinski deleted the live-update branch October 1, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants