Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ABC from collections.abc for Python 3.10 compatibility. #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tirkarthi
Copy link

What does this do and why?

Import ABC from collections.abc for Python 3.10 compatibility. Using collections was deprecated and removed in Python 3.10 . This PR is compatible with Python 3.6 and above but incompatible with Python 2.

Additional notes for reviewers

  • If applicable, include any information that provides context for these changes.

Testing

  • If these changes added new functionality, I tested them against the live API with real auth
  • I wrote tests covering these changes
  • Tests pass in the GitHub Actions CI for the following Python versions:
  • 3.6
  • 3.7
  • 3.8
  • 3.9

Airship Contribution Agreement

Link here

  • I've filled out and signed Airship's contribution agreement form

Screenshots

  • If applicable

@aschuman0
Copy link
Contributor

Thank you for the PR @tirkarthi ! We're working on python 3.10 compatibility for the next release. We'll get this rolled in at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants