Pass arch value to --platform
#153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LecrisUT
referenced
this pull request
in LecrisUT/run-on-arch-action
Oct 9, 2024
martin-g
reviewed
Oct 9, 2024
src/run-on-arch.sh
Outdated
|
|
||
| # Defaults | ||
| ACTION_DIR="$(cd "$(dirname "$0")"/.. >/dev/null 2>&1 ; pwd -P)" | ||
| LOWERCASE_REPOSITORY=$(printf "%s" "$GITHUB_REPOSITORY" | tr '[:upper:]' '[:lower:]') | ||
| PACKAGE_REGISTRY="ghcr.io/${LOWERCASE_REPOSITORY}/${CONTAINER_NAME}" | ||
| DEBIAN_FRONTEND=noninteractive | ||
|
|
||
| # Sanitize inputs | ||
| if [[ "$ARCH" == "none" ]]; then | ||
| unset ARCH |
There was a problem hiding this comment.
Suggested change
| unset ARCH | |
| export ARCH=amd64 |
There was a problem hiding this comment.
I was thinking if we should allow an interface to not pass --platform, that was the reason for unset approach
src/run-on-arch.sh
Outdated
| @@ -49,6 +55,7 @@ build_container () { | |||
| then | |||
| docker build \ | |||
| "${ACTION_DIR}/Dockerfiles" \ | |||
| ${ARCH:+--platform=linux/$ARCH} \ | |||
There was a problem hiding this comment.
Suggested change
| ${ARCH:+--platform=linux/$ARCH} \ | |
| --platform=linux/$ARCH \ |
src/run-on-arch.sh
Outdated
| @@ -70,6 +77,7 @@ build_container () { | |||
| docker pull "$PACKAGE_REGISTRY:latest" || true | |||
| docker build \ | |||
| "${ACTION_DIR}/Dockerfiles" \ | |||
| ${ARCH:+--platform=linux/$ARCH} \ | |||
There was a problem hiding this comment.
Suggested change
| ${ARCH:+--platform=linux/$ARCH} \ | |
| --platform=linux/$ARCH \ |
martin-g
reviewed
Oct 9, 2024
|
One other thing I should ask. I was able to debug locally with Edit: I've tried adding it to |
LecrisUT
force-pushed
the
fix/arch-flag
branch
from
7c5be02
to
919d47a
Compare
martin-g
reviewed
Oct 9, 2024
| @@ -49,6 +55,7 @@ build_container () { | |||
| then | |||
| docker build \ | |||
There was a problem hiding this comment.
Probably it will be a good idea to start using buildx instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from a debugging session in #152. It seems to resolve issues like: