Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new optional parameter
cachedImageTag
which allows overriding the otherwiseautomatically generated image tag. Reading #55 #100 and #56, I came to the conclusion, that having
the freedom to completely override the image tag would be most useful. There are also 2 other usecases for this:
One additional change was made:
The slug() function does not strictly adhere to the spec. See comments in
src/run-on-arch.js
, for an explanation, why I deliberately still deviate from that (but now it is still closer to the spec).Would be appreciated, if this could be considered for inclusion in #98
Cheers
-Fritz