-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
secondary structure analysis fix #153
Conversation
SamCox822
commented
Aug 6, 2024
•
edited
Loading
edited
- defaults to only last frame of trajectory when getting secondary structure residue counts
- better message indicating "x resides in ss" rather than just "x ss"
- fixed broken uniprot get id test
- removed stale nb experiments (rgy, rmsd, etc) that don't run anymore
- ensure that rgy figures do not overwrite each other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my individual comments
…ID instead of a path
… of the simulation has been calculated and saved to avoid repetition
… of the simulation has been calculated and saved to avoid repetition
Made some small changes in rgy tools, only one bug related to the path registry: It was saving the path as the id:
Also, in case these tools are used sequentially, also included a check to see if the radii csv file was already saved, to avoid repetition on the calculation. |
Corrected a bug related to the path registry in dssp:
Now it saves as:
With the correct file name and path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may want to add a print statement if RGy file already exists and skip the calculation (Line 34 in rgy.py). Otherwise, lgtm.