Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secondary structure analysis fix #153

Merged
merged 17 commits into from
Aug 8, 2024
Merged

secondary structure analysis fix #153

merged 17 commits into from
Aug 8, 2024

Conversation

SamCox822
Copy link
Contributor

@SamCox822 SamCox822 commented Aug 6, 2024

  • defaults to only last frame of trajectory when getting secondary structure residue counts
  • better message indicating "x resides in ss" rather than just "x ss"
  • fixed broken uniprot get id test
  • removed stale nb experiments (rgy, rmsd, etc) that don't run anymore
  • ensure that rgy figures do not overwrite each other

@SamCox822 SamCox822 requested a review from Jgmedina95 August 6, 2024 05:44
@SamCox822 SamCox822 requested a review from qcampbel August 7, 2024 17:25
Copy link
Contributor

@Jgmedina95 Jgmedina95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my individual comments

@SamCox822 SamCox822 requested a review from Jgmedina95 August 8, 2024 04:55
SamCox822 and others added 4 commits August 7, 2024 21:59
… of the simulation has been calculated and saved to avoid repetition
… of the simulation has been calculated and saved to avoid repetition
@Jgmedina95
Copy link
Contributor

Made some small changes in rgy tools, only one bug related to the path registry: It was saving the path as the id:

"/Users/jorgemedina/Desktop/md-agent/ckpt/ckpt_1/figures/radii_of_gyration_rec0_215810.csv": {
       "path": "/Users/jorgemedina/Desktop/md-agent/ckpt/ckpt_1/figures/radii_of_gyration_rec0_215810.csv",
       "name": "radii_of_gyration_rec0_215810.csv",
       "description": "Radii of gyration per frame for rec0_215810"
   }

Also, in case these tools are used sequentially, also included a check to see if the radii csv file was already saved, to avoid repetition on the calculation.

@Jgmedina95
Copy link
Contributor

Corrected a bug related to the path registry in dssp:

    "rec0_110717": {
        "path": "/Users/jorgemedina/Desktop/md-agent/mdagent/dssp_20240808_110717.No file format provided",
        "name": "dssp_20240808_110717.No file format provided",
        "description": "dssp values for trajectory with id: rec0_215810"
    },

Now it saves as:

    "rec0_111801": {
        "path": "/Users/jorgemedina/Desktop/md-agent/ckpt/ckpt_1/records/dssp_20240808_111801.npy",
        "name": "dssp_20240808_111801.npy",
        "description": "dssp values for trajectory with id: rec0_215810"
    }

With the correct file name and path

Copy link
Contributor

@qcampbel qcampbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may want to add a print statement if RGy file already exists and skip the calculation (Line 34 in rgy.py). Otherwise, lgtm.

@SamCox822 SamCox822 merged commit c2ae2f9 into main Aug 8, 2024
1 check passed
@SamCox822 SamCox822 deleted the ss_analysis_fix branch August 8, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants