Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug records #90

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Bug records #90

merged 7 commits into from
Feb 21, 2024

Conversation

Jgmedina95
Copy link
Contributor

as mentiones in the issue #89. Record files from a simulation were not correctly been saved in the path registry because the ID was the same. Besides the change in the path_registry.get_id function, I also changed how the records are saved in the end of the setup and run function. In the end, all records are saved in the path registry and the respective IDs are given back to the agent in the result of the tool.

@Jgmedina95 Jgmedina95 linked an issue Feb 21, 2024 that may be closed by this pull request
Copy link
Contributor

@SamCox822 SamCox822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jgmedina95 Jgmedina95 merged commit 4498a76 into main Feb 21, 2024
1 check passed
@Jgmedina95 Jgmedina95 deleted the bug-records-id branch March 11, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two record or simulation files can get the same ID
2 participants