Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn flag #85

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Learn flag #85

merged 5 commits into from
Feb 21, 2024

Conversation

SamCox822
Copy link
Contributor

I added a learn flag to mdagent. This is so that if you want to force mdagent to only use existing/learned skills, rather than learn new skills, you can. I also added the flag to streamlit & added a unit test for initializing mdagent with the flag.

@Jgmedina95
Copy link
Contributor

Jgmedina95 commented Feb 14, 2024

If im getting this right, the learn flag lets you use the Structure agent, but without it you can only use OpenAIfxns?

        if learn:
             if agent_type == "Structured":
                 self.prompt = structured_prompt
             elif agent_type == "OpenAIFunctionsAgent":
                 self.prompt = openaifxn_prompt
             self.skip_subagents = False
         else:
             self.prompt = openaifxn_prompt
             self.skip_subagents = True

@qcampbel
Copy link
Contributor

I concur with Jorge's comment. Since it's related to learning, can we also add confirmation message with Yes/No option whenever mdagent chooses to use CreateNewTool?

@SamCox822
Copy link
Contributor Author

I concur with Jorge's comment. Since it's related to learning, can we also add confirmation message with Yes/No option whenever mdagent chooses to use CreateNewTool?

If I understand this, you want the system to ask the user every single time it goes to create a new tool? I don't think we want that

@qcampbel
Copy link
Contributor

I concur with Jorge's comment. Since it's related to learning, can we also add confirmation message with Yes/No option whenever mdagent chooses to use CreateNewTool?

If I understand this, you want the system to ask the user every single time it goes to create a new tool? I don't think we want that

ignore what I said then haha. I think I just became paranoid about using extra LLMs for a moment lol

@SamCox822 SamCox822 linked an issue Feb 21, 2024 that may be closed by this pull request
Copy link
Contributor

@Jgmedina95 Jgmedina95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, make sure to pull main first. I merged a PR earlier

@SamCox822 SamCox822 merged commit 456e012 into main Feb 21, 2024
1 check passed
@SamCox822 SamCox822 deleted the learn_flag branch February 21, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] User can decide to "learn" or not.
3 participants