Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

80-adding-solvate-option-in-setupandrun-tool #84

Merged
merged 6 commits into from
Feb 14, 2024

Conversation

Jgmedina95
Copy link
Contributor

As part of my action items from yesterday meeting.

Im adding the option to solvate the protein directly using modeller.addSolvent. This way, the agent can do a simulation directly without using packmol to just add water to the simulation.

The prompt for testing was:
""Simulate 1A3N in water at 280K. Dont forget to clean the protein first"

The second part is just to make it work quicker. The agent still needs the warning from the tools to then clean the file most of the time.

@Jgmedina95 Jgmedina95 added the enhancement New feature or request label Feb 8, 2024
@Jgmedina95 Jgmedina95 marked this pull request as ready for review February 8, 2024 20:07
@Jgmedina95 Jgmedina95 linked an issue Feb 8, 2024 that may be closed by this pull request
Copy link
Contributor

@qcampbel qcampbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Consider commenting out the old unused code

@Jgmedina95 Jgmedina95 merged commit dae6379 into main Feb 14, 2024
1 check passed
@Jgmedina95 Jgmedina95 deleted the 80-adding-solvate-option-in-setupandrun-tool branch February 14, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Up and Run doesn't has any use of the modeler
2 participants