Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to use rdkit for small mol pdb #76

Merged
merged 14 commits into from
Feb 7, 2024

Conversation

SamCox822
Copy link
Contributor

@SamCox822 SamCox822 commented Jan 31, 2024

  • a new tool that takes in a mol name/smiles and creates a pdb file for it using rdkit
  • Packmol now explicitly takes in a list of small molecules, which are downloaded if not already
  • unit tests for the download pdb and the download pdb part of Packmol tool

@SamCox822 SamCox822 requested a review from Jgmedina95 January 31, 2024 22:12
This was linked to issues Jan 31, 2024
@Jgmedina95
Copy link
Contributor

Just went through it quickly. Looks very good, and I think is an improvement. It also reduces the dependency on path_registry to work all the time. Ill test it later today but couple questions to think about:

  1. Should we remove solvents from the path_registry then? i differentiate in different directories cause pdb was intended for proteins and solvents for single small molecules that are used as solvents.
  2. I don't know if this is overthinking, but I'm concerned the agent will think a small protein (ALA I think?) for example is a small molecule too? maybe include this in some more detail in the tool description.
  3. I noted your using document strings, """ """, in descriptions and return statements. I would like to change those in ("") as it formates prettier inside the agent (as explained before in the slack channel).
  4. Again, love the idea hjaha I'm going to test it later today after couple meetings :)

@SamCox822
Copy link
Contributor Author

SamCox822 commented Feb 5, 2024

@Jgmedina95

  1. Should we remove solvents from the path_registry then? i differentiate in different directories cause pdb was intended for proteins and solvents for single small molecules that are used as solvents.

I don't think we need the folders? what do you think?

  1. I don't know if this is overthinking, but I'm concerned the agent will think a small protein (ALA I think?) for example is a small molecule too? maybe include this in some more detail in the tool description.

I don't think this is particularly concerning. I doubt this will happen, and if it does, it will either realize its mistake via error messages or end up using the small molecule route to get a pdb file...which should still be a valid pdb file.

  1. I noted your using document strings, """ """, in descriptions and return statements. I would like to change those in ("") as it formates prettier inside the agent (as explained before in the slack channel).

fixed

@Jgmedina95
Copy link
Contributor

as we talked earlier. Ill work to combine this with mine (#72) as this PR will make some of the code not useful.

@Jgmedina95
Copy link
Contributor

Done!

@SamCox822
Copy link
Contributor Author

@Jgmedina95 my only concern now is that I don't think we need/should have pdb files for water & urea downloaded & saved in our repo. I don't think its particularly useful

@Jgmedina95
Copy link
Contributor

Agree, it is unnecessary now.

@Jgmedina95
Copy link
Contributor

@SamCox822 I was going to delete them, but they are already deleted! haha

@SamCox822 SamCox822 merged commit 574d28e into 72-lack-of-solvents-for-packmol-tool Feb 7, 2024
1 check passed
@SamCox822 SamCox822 deleted the rdkit_pdb branch February 7, 2024 17:45
Jgmedina95 added a commit that referenced this pull request Feb 7, 2024
* Improve path_registry init to initialize with files already downloaded in the files/ directory

* Fixing packmol: 1. Moving the input validator inside the tool. 2. Packmol needs the pdb files in the same directory. files/pdb doesn't work; Corrected copy and pasting temporarily the pdb files from the path_registry and deleting after termination

* Solved unrelated bugs in cleaning tools, mainly from path_registry calls.

* Add new tool to make pdb files from small molecules names or smiles. Also include this functionality directly in packmol function with new parameter small_molecules. (#76)

---------

Co-authored-by: Sam Cox <[email protected]>
@Jgmedina95 Jgmedina95 mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small Molecule PDBs Lack of solvents for Packmol tool
2 participants