-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trying to use rdkit for small mol pdb #76
Conversation
SamCox822
commented
Jan 31, 2024
•
edited
Loading
edited
- a new tool that takes in a mol name/smiles and creates a pdb file for it using rdkit
- Packmol now explicitly takes in a list of small molecules, which are downloaded if not already
- unit tests for the download pdb and the download pdb part of Packmol tool
Just went through it quickly. Looks very good, and I think is an improvement. It also reduces the dependency on path_registry to work all the time. Ill test it later today but couple questions to think about:
|
I don't think we need the folders? what do you think?
I don't think this is particularly concerning. I doubt this will happen, and if it does, it will either realize its mistake via error messages or end up using the small molecule route to get a pdb file...which should still be a valid pdb file.
fixed |
as we talked earlier. Ill work to combine this with mine (#72) as this PR will make some of the code not useful. |
…d 'center' as an incorrect instruction, 3. Make the file be registered to the correct file path in the registry
Done! |
@Jgmedina95 my only concern now is that I don't think we need/should have pdb files for water & urea downloaded & saved in our repo. I don't think its particularly useful |
Agree, it is unnecessary now. |
@SamCox822 I was going to delete them, but they are already deleted! haha |
574d28e
into
72-lack-of-solvents-for-packmol-tool
* Improve path_registry init to initialize with files already downloaded in the files/ directory * Fixing packmol: 1. Moving the input validator inside the tool. 2. Packmol needs the pdb files in the same directory. files/pdb doesn't work; Corrected copy and pasting temporarily the pdb files from the path_registry and deleting after termination * Solved unrelated bugs in cleaning tools, mainly from path_registry calls. * Add new tool to make pdb files from small molecules names or smiles. Also include this functionality directly in packmol function with new parameter small_molecules. (#76) --------- Co-authored-by: Sam Cox <[email protected]>