Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added streamlit app with ability to upload files #74

Merged
merged 6 commits into from
Feb 5, 2024
Merged

added streamlit app with ability to upload files #74

merged 6 commits into from
Feb 5, 2024

Conversation

SamCox822
Copy link
Contributor

@SamCox822 SamCox822 commented Jan 29, 2024 •
edited
Loading

just for fun

This PR, specifically:

  • Instructions added to readme
  • streamlit package added to setup
  • some logging messages duplicated (previously just printed to terminal - now also to streamlit app)
  • streamlit app added -> when files are uploaded, they get added to registry

Things we can do in the future:

  • more add st.markdown lines to print directly to the app as needed
  • add ability to handle different file types
  • implement chat model & use streamlit app to chat

@SamCox822 SamCox822 requested review from qcampbel, Jgmedina95 and brittyscience and removed request for Jgmedina95 and qcampbel January 29, 2024 20:44
@SamCox822
Copy link
Contributor Author

@brittyscience this is ready for review - can you take a look when you get a chance? thanks!

@SamCox822 SamCox822 linked an issue Jan 29, 2024 that may be closed by this pull request
Streamlit App #75
Closed
@SamCox822 SamCox822 added the enhancement New feature or request label Jan 29, 2024
brittyscience
brittyscience requested changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@brittyscience brittyscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted a possible typo in line 321.

brittyscience
brittyscience requested changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@brittyscience brittyscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unclear if this is a "PR" or a simple review of a commit. Did you mean .CSV or .CIF file? The streamlit was tested and run, it appears that .CIF is the standard format from PDB.

brittyscience
brittyscience approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@brittyscience brittyscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have witnesses. PR approved :)

@SamCox822 SamCox822 merged commit ba4fc9c into main Feb 5, 2024
1 check passed
@SamCox822 SamCox822 deleted the streamlit branch February 5, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brittyscience brittyscience brittyscience approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Streamlit App
2 participants
@SamCox822 @brittyscience