Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging Prior to Eval #67

Merged
merged 9 commits into from
Jan 25, 2024
Merged

Debugging Prior to Eval #67

merged 9 commits into from
Jan 25, 2024

Conversation

Jgmedina95
Copy link
Contributor

  1. Add *arg detecter in the modified simul tool.
  2. Improve string printing inside the agent with ("") format

@Jgmedina95 Jgmedina95 requested a review from SamCox822 January 20, 2024 21:47
Jgmedina95 and others added 6 commits January 20, 2024 19:02
…Change stucture in make_tools so modifyscript is with other llm tools. 3. Fix bug at modifyscriputils during its init (added the llm when called)
 1. add FileType.RECORD functionality in writefilenames and get ids at the path registry (write name and get id)
 2. Add handling temp files in setup and run: if final record files are saved in the path registry, if not they get deleted.
@Jgmedina95 Jgmedina95 changed the title *args checker inside Modify Script Tool Debugging Prior to Eval Jan 23, 2024
SamCox822
SamCox822 previously approved these changes Jan 24, 2024
Copy link
Contributor

@SamCox822 SamCox822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with "Run a simulation for 1A3N for 1ps. Make sure to clean the pdb file." and it works fine

@SamCox822 SamCox822 self-requested a review January 24, 2024 18:45
@SamCox822 SamCox822 dismissed their stale review January 24, 2024 18:47

bug in cleaning tool

if serp_key:
all_tools.append(SerpGitTool(serp_key)) # github issues search
# if serp_key:
# all_tools.append(SerpGitTool(serp_key)) # github issues search
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we removing GitHub issue search tool?

@Jgmedina95 Jgmedina95 merged commit 60bb0e6 into main Jan 25, 2024
1 check passed
@Jgmedina95
Copy link
Contributor Author

@qcampbel On your comment, im not sure yet. Every time is been used it seems to hurt progress rather than helped so far.

@Jgmedina95 Jgmedina95 deleted the inputsinModifySimulationTool branch January 29, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants