Polymorphic method type #1889
Merged
Polymorphic method type #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PalumboN
commented
May 8, 2020
| var property x = obj1 | ||
| } | ||
| '''.parseAndInfer.asserting [ | ||
| // FIXME |
This was referenced May 8, 2020
|
@fdodino me está fallando el build por algo de |
fdodino
approved these changes
May 9, 2020
| var property x = obj1 | ||
| } | ||
| '''.parseAndInfer.asserting [ | ||
| // FIXME |
| @@ -27,10 +27,10 @@ program p { | |||
| // XPECT type at c6 --> {() => Number} | |||
| const c6 = { if (bool) return 1 else return 2 } | |||
|
|
|||
| // XPECT type at c7 --> {() => (Number|String)} | |||
| // XPECT type at c7 --> {() => Number} | |||
There was a problem hiding this comment.
acá no entendí si corregiste el type system para que tire error cuando hacés
if (bool) { return 1 }
return "2"lo cual me parece razonable y piola.
There was a problem hiding this comment.
Sí, exactamente eso, porque Number y String ahora no son "compatibles". Esta es una regla media arbitraria, pero había varios tests en donde se esperaba este comportamiento, y no me parecían mal. Ahora el TS es más restrictivo, pero no creo que haya casos así en pdep/obj1 y que no impliquen un "error de diseño".
...ypeSystem/src/org/uqbar/project/wollok/typesystem/constraints/types/CompatibilityTypes.xtend
Outdated
Show resolved
Hide resolved
…lymorphic-method-type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1770
Fix #1745
Fix #1735
Fix #1526
Fix #1507
Fix #1478
Este PR soluciona problemas con la inferencia, en donde el uso de un método pesaba más que su definición y producía que se infiera un tipo más acotado para los parámetros.
Ahora los tipos de los métodos se infieren a partir de su uso, buscando el tipo más amplio.
El buscar el tipo más amplio, me llevó a inferencias del tipo
(Number|String)que se esperaban que dieran error. Así que metí el concepto de tipos compatibles para ver en qué casos hacer union y en qué casos fallar.Pueden ver los tests para más detalles