This repository has been archived by the owner on May 12, 2023. It is now read-only.
Keremserttas hw4 #106
Open
Keremserttas hw4 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upy
reviewed
Jan 12, 2022
| @@ -15,6 +22,11 @@ class BasketItemViewSet(DetailedViewSetMixin, viewsets.ModelViewSet): | |||
| "detailed": BasketItemDetailedSerializer, | |||
| } | |||
|
|
|||
| def get_queryset(self): | |||
| queryset = super().get_queryset() | |||
| user = self.request.user | |||
There was a problem hiding this comment.
login olmamis bir kullanici durumunda problem olusuyor sanki?
|
|
||
| def get_queryset(self): | ||
| queryset = super().get_queryset() | ||
| user = self.request.user |
There was a problem hiding this comment.
login olmamis bir kullanici durumunda problem olusuyor sanki?
| basket_item.quantity += quantity | ||
|
|
||
| else: | ||
| basket_item = BasketItem.objects.create(basket=basket, product=product, quantity=quantity,price=price) |
There was a problem hiding this comment.
kayit insert/update validation islemlerini serializer uzerinden yapmamizda fayda var.
| basket_item.save() | ||
| basket.save() | ||
|
|
||
| serializer = BasketItemSerializer(basket) |
There was a problem hiding this comment.
basket viewseti basket e ait bir serializer datasi donmesi daha iyi bir fikir olur.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register Endpoint added, DRF action is added for adding net basketItem to basket. Viewsets are updated regarding their permissions.