fix: auto add alias for order column added via Column() method if the colu… #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… column in the table FieldMap
|
This requires better explanation of what you are trying to achieve and what are the alternatives. TBH I am not big fan of having queries the result of which depend on the previous state of |
|
If I have a SQL query with multiple table joins, when I specify to sort by This semantic is consistent with the |
|
@ilxqx okay, could you please update query_test.go with some examples that demonstrate your point? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto add alias for order column added via Column() method if the column in the table FieldMap