Support AUTOINCREMENT directive in SQLite #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmihailenco
reviewed
Jan 6, 2024
vmihailenco
reviewed
Jan 6, 2024
vmihailenco
approved these changes
Jan 6, 2024
|
@bevzzz looks good with few notes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment
sqlitedialect ignoresbun:",autoincrement"tag, relying on the defaultROWIDbehaviour instead.However,
AUTOINCREMENTkeyword is a separate instruction in SQLite that creates a dedicated sequence and changes how the unique IDs for the table are generated.Related issue: #929
This PR adds support for
AUTOINCREMENTkeyword for fields which have theautoincrementtag. See the docs forsqlitedialect.Dialect.AppendSequencefor more details.I also noticed that each dialect has different keywords for creating generated columns, so I also pushed this logic to the dialects' via new
AppendSequencemethod.