-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment preview workflow #203
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
@hexsecs please review this PR |
We need to investigate how to make this secure. We don't want to allow anyone to arbitrarily publish to the uptane.org domain by issuing a pull request. |
1 similar comment
We need to investigate how to make this secure. We don't want to allow anyone to arbitrarily publish to the uptane.org domain by issuing a pull request. |
I missed this one when it first came around. The security part can be solved by a setting in the repository permissions @hexsecs : We already have it set so that a PR from a first-time contributor won't automatically trigger any workflows; we can potentially tighten it up more so that it requires manual approval to run all workflows for external contributors. I think I'm ok with the risk profile of our current setting. |
Github posted a blog about this a couple years ago when they introduced the feature: https://github.blog/open-source/maintainers/github-actions-update-helping-maintainers-combat-bad-actors/ |
Summary of Changes
Created a new yml file and updated workflow
Related Issue
Closes #91
Checklist
Screenshots (if applicable)
Attach any screenshots or images related to the changes.
Additional Context
Add any additional context or information that might be helpful for reviewers.
Reviewer(s)
@Abhijay007 @jhdalek55