-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration for Tailwind Integration #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @devilkiller-ag, I've reviewed the code, and there are a few things that need to be considered. The Initialization of Tailwind to our Docusaurus site looks good to me, as it didn't break our site too much. However, some styling changes seem to have been adopted due to Tailwind, so we need to look into that. For instance, take a look at these screenshots here.
- one the blog page
- on docs pages
This issue needs to be resolved. Most of the custom components appear to be in good shape. To address these concerns, we may need to delve into the styles of custom CSS and adjust them accordingly using Tailwind. While you can incorporate these changes in the same file, I recommend considering a separate file for Tailwind, as demonstrated in the resources I shared earlier.
Let's ensure everything aligns smoothly with our design standards, it will help us in long run to use tailwind effectively.
Sure @Abhijay007, I will look into this. |
Hi @Abhijay007, I have made changes to the heading styling. However, I think I will need to convert the whole custom.css into tailwind, to fix the styling. I am currently doing these changes in a different CSS file. I have changed the heading styling into tailwind in the above commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes LGTM. Now, you can work on converting one of the components and create a separate PR for that. Once that's done, we will merge both of these PRs.
Okay Sure! |
This reverts commit a957e26.
closing this as we already have version of it here : #185 |
Summary of Changes
This PR adds configuration for Tailwind CSS
Related Issue
Fixes first task of #179
Checklist
Reviewer(s)
@Abhijay007