Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration for Tailwind Integration #182

Closed
wants to merge 6 commits into from

Conversation

devilkiller-ag
Copy link
Contributor

Summary of Changes

This PR adds configuration for Tailwind CSS

Related Issue

Fixes first task of #179

Checklist

  • I have read and followed the project's contribution guidelines, including code style and commit message conventions.
  • My code is well-documented, and I've updated relevant documentation.
  • I have added or updated test cases to ensure the code's functionality.
  • I have tested these changes on my local environment.
  • All tests pass, and there are no new linting errors.
  • I have reviewed and proofread my code and the changes.
  • The branch is up-to-date with the base branch.

Reviewer(s)

@Abhijay007

@Abhijay007 Abhijay007 self-requested a review February 2, 2024 17:51
Copy link
Collaborator

@Abhijay007 Abhijay007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @devilkiller-ag, I've reviewed the code, and there are a few things that need to be considered. The Initialization of Tailwind to our Docusaurus site looks good to me, as it didn't break our site too much. However, some styling changes seem to have been adopted due to Tailwind, so we need to look into that. For instance, take a look at these screenshots here.

  • one the blog page

image

Screenshot 2024-02-04 143725

  • on docs pages

Screenshot 2024-02-04 143701

Screenshot 2024-02-04 143558

This issue needs to be resolved. Most of the custom components appear to be in good shape. To address these concerns, we may need to delve into the styles of custom CSS and adjust them accordingly using Tailwind. While you can incorporate these changes in the same file, I recommend considering a separate file for Tailwind, as demonstrated in the resources I shared earlier.

Let's ensure everything aligns smoothly with our design standards, it will help us in long run to use tailwind effectively.

@devilkiller-ag
Copy link
Contributor Author

Sure @Abhijay007, I will look into this.

@devilkiller-ag
Copy link
Contributor Author

Hi @Abhijay007, I have made changes to the heading styling. However, I think I will need to convert the whole custom.css into tailwind, to fix the styling. I am currently doing these changes in a different CSS file. I have changed the heading styling into tailwind in the above commit.

@Abhijay007 Abhijay007 self-requested a review February 7, 2024 17:27
Abhijay007
Abhijay007 previously approved these changes Feb 8, 2024
Copy link
Collaborator

@Abhijay007 Abhijay007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM. Now, you can work on converting one of the components and create a separate PR for that. Once that's done, we will merge both of these PRs.

@Abhijay007 Abhijay007 requested a review from hexsecs February 8, 2024 18:11
@devilkiller-ag
Copy link
Contributor Author

The code changes LGTM. Now, you can work on converting one of the components and create a separate PR for that. Once that's done, we will merge both of these PRs.

Okay Sure!

@Abhijay007
Copy link
Collaborator

closing this as we already have version of it here : #185

@Abhijay007 Abhijay007 closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants