Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add contributors react component in the website #163

Merged
merged 10 commits into from
Jan 19, 2024
Merged

feature: add contributors react component in the website #163

merged 10 commits into from
Jan 19, 2024

Conversation

devilkiller-ag
Copy link
Contributor

@devilkiller-ag devilkiller-ag commented Dec 13, 2023 •
edited
Loading

Summary of Changes

As discussed in #144 this PR will add a contributors section on the website.

Related Issue

Closes #160

Checklist

  • I have read and followed the project's contribution guidelines, including code style and commit message conventions.
  • My code is well-documented, and I've updated relevant documentation.
  • I have added or updated test cases to ensure the code's functionality.
  • I have tested these changes on my local environment.
  • All tests pass, and there are no new linting errors.
  • I have reviewed and proofread my code and the changes.
  • The branch is up-to-date with the base branch.

Reviewer(s)

@Abhijay007

@devilkiller-ag devilkiller-ag marked this pull request as draft December 13, 2023 08:41
@devilkiller-ag
Copy link
Contributor Author

devilkiller-ag commented Dec 13, 2023 •
edited
Loading

@Abhijay007 I have written a script for fetching the contributors' data from all repositories of our organization. But to run it regularly, we will need a GitHub access token in the future. For now, I am using mine for development.

@argos-ci Argos CI
Copy link

argos-ci bot commented Dec 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 8 changes Jan 17, 2024, 5:36 PM

@Abhijay007
Copy link
Collaborator

@Abhijay007 I have written a script for fetching the contributors' data from all repositories of our organization. But to run it regularly, we will need a GitHub access token in the future. For now, I am using mine for development.

No problem I will add that

@devilkiller-ag
Copy link
Contributor Author

devilkiller-ag commented Dec 14, 2023 •
edited
Loading

Hi @Abhijay007, you will need to create a GitHub secret with the name GH_ACCESS_TOKEN for this website repository, so that the fetch contributor workflow runs every midnight or can we use the existing DEPLOYMENT_TOKEN for this?

@devilkiller-ag
Copy link
Contributor Author

I fetched the current contributors list using my personal access token so now we can work on the react component for showcasing the contributors on our website.

@devilkiller-ag devilkiller-ag marked this pull request as ready for review December 15, 2023 04:32
@devilkiller-ag
Copy link
Contributor Author

@Abhijay007 This PR is ready for review now!

@Abhijay007
Copy link
Collaborator

Abhijay007 commented Dec 15, 2023 •
edited
Loading

@Abhijay007 I have written a script for fetching the contributors' data from all repositories of our organization. But to run it regularly, we will need a GitHub access token in the future. For now, I am using mine for development.

No problem I will add that

I don't have the access to great token as it require admin permissions ig, @hexsecs can help for the same

@devilkiller-ag
Copy link
Contributor Author

devilkiller-ag commented Dec 15, 2023 •
edited by Abhijay007
Loading

Hi @Abhijay007, you will need to create a GitHub secret with the name GH_ACCESS_TOKEN for this website repository, so that the fetch contributor workflow runs every midnight or can we use the existing DEPLOYMENT_TOKEN for this?

@Abhijay007 @hexsecs , If you allow I can also use DEPLOYMENT_TOKEN for this.

@devilkiller-ag
Copy link
Contributor Author

Hi @Abhijay007, Any updates on this?

@Abhijay007
Copy link
Collaborator

Hi @Abhijay007, Any updates on this?

I will look into this code, @hexsecs can check the token permissions

Abhijay007
Abhijay007 requested changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@Abhijay007 Abhijay007 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devilkiller-ag I looked into the code, and it LGTM. However, in terms of design, do you have any better suggestions? I think it looks too busy.

image

Can we make it scrollable or something? Do you have any better suggestions around the same?

cc : @jhdalek55 @hexsecs

@devilkiller-ag
Copy link
Contributor Author

@Abhijay007 We can restrict the number of rows to 3 to make it automated horizontal scroll.

@Abhijay007
Copy link
Collaborator

@Abhijay007 We can restrict the number of rows to 3 to make it automated horizontal scroll.

great suggestion, I think we can go ahead with this one

@Abhijay007
Copy link
Collaborator

@Abhijay007 We can restrict the number of rows to 3 to make it automated horizontal scroll.

@devilkiller-ag instead of iterating it please move it to the "About Us" page here at very bottom

@devilkiller-ag
Copy link
Contributor Author

@Abhijay007 So I don't need to add a horizontal scroll now? Just move the section to about us page?

@Abhijay007
Copy link
Collaborator

Abhijay007 commented Jan 6, 2024 via email

@devilkiller-ag
Copy link
Contributor Author

@Abhijay007 Can you review the changes and approve on argos

@Abhijay007
Copy link
Collaborator

@Abhijay007 Can you review the changes and approve on argos

looking into this, will review it soon

@hexsecs
Copy link
Member

hexsecs commented Jan 10, 2024

Hi @devilkiller-ag - for me it isn't quite rendering correctly when I build locally.

image

@devilkiller-ag
Copy link
Contributor Author

@hexsecs It should wor now!

@devilkiller-ag
Copy link
Contributor Author

Any update on this @Abhijay007 @hexsecs?

@devilkiller-ag
Copy link
Contributor Author

@hexsecs @Abhijay007 I resolved the changes requested.

Abhijay007
Abhijay007 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@Abhijay007 Abhijay007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hexsecs hexsecs merged commit 981d243 into uptane:main Jan 19, 2024
2 of 3 checks passed
@devilkiller-ag devilkiller-ag mentioned this pull request Jan 20, 2024
Open
@devilkiller-ag devilkiller-ag deleted the ag-dev-rc branch February 2, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhijay007 Abhijay007 Abhijay007 approved these changes

@JustinCappos JustinCappos Awaiting requested review from JustinCappos

@tkfu tkfu Awaiting requested review from tkfu

@hexsecs hexsecs Awaiting requested review from hexsecs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal for Adding "Uptane Contributors" Section to the Website and Workflow Integration
3 participants
@devilkiller-ag @Abhijay007 @hexsecs