Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sleep after the last retry attempt #1342

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Remove sleep after the last retry attempt #1342

merged 4 commits into from
Nov 6, 2024

Conversation

CahidArda
Copy link
Contributor

The http client would sleep event after the last retry, which resulted in the following behavior:

failing
sleeping 50
failing
sleeping 135.91409142295225
failing
sleeping 369.4528049465325
failing
sleeping 1004.2768461593834
failing
sleeping 2729.907501657212
failing
sleeping 7420.65795512883
throw

now the last sleep is removed. Error is thrown immedietly after the last (5th) retry failure.

@linear Linear
Copy link

linear bot commented Nov 4, 2024

DX-1338 Fix retry logic in vector and redis sdks

This was referenced Nov 4, 2024
Merged
Merged
@CahidArda CahidArda mentioned this pull request Nov 5, 2024
Open
@CahidArda CahidArda merged commit a1b6b4b into main Nov 6, 2024
14 checks passed
@CahidArda CahidArda deleted the DX-1338-retry branch November 6, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytkimirti ytkimirti ytkimirti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CahidArda @ytkimirti