Cockroach delete limit (#697)

* DELETE FROM must have LIMIT support CockroachDB is not able to deal well with massive deletes and their recommended approach is to batch delete statements. Thus, support for LIMIT statement is a must in the adapter. * Updated tests
upper · Nov 5, 2023 · 5025ae3 · 5025ae3
1 parent 8e61801
commit 5025ae3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/adapter/cockroachdb/template.go b/adapter/cockroachdb/template.go
@@ -123,6 +123,9 @@ const (
     DELETE
       FROM {{.Table | compile}}
       {{.Where | compile}}
+      {{if .Limit}}
+        LIMIT {{.Limit}}
+      {{end}}
   `
 	adapterUpdateLayout = `
     UPDATE

diff --git a/adapter/cockroachdb/template_test.go b/adapter/cockroachdb/template_test.go
@@ -259,4 +259,9 @@ func TestTemplateDelete(t *testing.T) {
 		`DELETE FROM "artist" WHERE (id > 5)`,
 		b.DeleteFrom("artist").Where("id > 5").String(),
 	)
+
+	assert.Equal(
+		`DELETE FROM "artist" WHERE (id > 5) LIMIT 10`,
+		b.DeleteFrom("artist").Where("id > 5").Limit(10).String(),
+	)
 }