OSS::InformationSection component #457
Conversation
| import type { IconNames } from './iconName.enum'; | ||
|
|
||
| interface InformationSectionArgs { | ||
| imageBadge: keyof typeof IconNames | string; |
| <:content> | ||
| <p data-control-name='content-named-block'>{{this.namedBlockContent}}</p> | ||
| </:content> | ||
| </OSS::InformationSection>`); |
There was a problem hiding this comment.
nit: alignment of the
tag
It also looks like you have an empty state after each await render statement in some of the tests of the file
|
|
||
| interface InformationSectionArgs { | ||
| badgeIcon?: keyof typeof IconNames; | ||
| svgIcon?: string; |
There was a problem hiding this comment.
imageUrl should be a bit more "permissive" language wise :)
the icons might be pngs sometimes
There was a problem hiding this comment.
Changed to imageUrl
| export default { | ||
| title: 'Components/OSS::InformationSection', | ||
| argTypes: { | ||
| title: { |
There was a problem hiding this comment.
you can be a little more precise with the argTypes in storybook, there are examples in other files in the project
table: {
type: { summary: 'string' },
defaultValue: { summary: 'undefined' }
},
control: {
type: 'text'
}There was a problem hiding this comment.
Specified argTypes in sb
There was a problem hiding this comment.
I think the defaultValues are wrong ^^
should be 'undefined' everywhere no ? 🤷
| <div class="fx-row fx-gap-px-6"> | ||
| <OSS::Tag @label="Hello" @skin="primary" /> | ||
| <OSS::Button @size="sm" @label="Action Button"/> | ||
| </div> |
There was a problem hiding this comment.
Fixed indentation
upfluence-bot
added
reviewed/needs-work
and removed
reviewed/needs-review
reviewed/needs-work
labels
upfluence-bot
added
reviewed/needs-review
reviewed/needs-work
and removed
reviewed/needs-work
reviewed/needs-review
labels
| export default { | ||
| title: 'Components/OSS::InformationSection', | ||
| argTypes: { | ||
| title: { |
There was a problem hiding this comment.
I think the defaultValues are wrong ^^
should be 'undefined' everywhere no ? 🤷
What does this PR do?
It adds a new component used in the 2FA project
Related to: #
What are the observable changes?
Good PR checklist