Dummy app winter cleanup #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathalieArnoux
force-pushed
the
na/VEL-3968
branch
from
a0a1d11 to
6c8c969
Compare
nathalieArnoux
force-pushed
the
na/VEL-3968
branch
from
12f383a to
9ea5367
Compare
JulienVannier66
approved these changes
Dec 16, 2024
Comment on lines
+70
to
+71
| padding: 12px; | ||
| margin: 18px auto 18px auto; |
There was a problem hiding this comment.
Suggested change
| padding: 12px; | |
| margin: 18px auto 18px auto; | |
| padding: var(--spacing-px-12); | |
| margin: var(--spacing-px-18) auto var(--spacing-px-18) auto; |
|
|
||
| </div> | ||
|
|
||
| {{!-- <div class="fx-col fx-gap-px-6 padding-px-18"> |
There was a problem hiding this comment.
Do you want to keep all this part commented?
| <div class="page-title-container"> | ||
| <span class="font-size-h2 font-weight-semibold">Overlay</span> | ||
| <span class="font-color-gray-500">Components used to display information on the foreground</span> | ||
| <span class="font-color-gray-500 font-size-xs text-style-italic">(c'est qui qu'est over laid ?)</span> |
upfluence-bot
added
reviewed/ready-to-merge
and removed
reviewed/needs-review
reviewed/ready-to-merge
labels
Miexil
approved these changes
Dec 17, 2024
OwenCoogan
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to: #VEL-3968
Complete reorganization of the OSS Components Dummy App into different pages for better organization and navigation.
Information on the repartition of the components is available in the spreadsheet here.
Good PR checklist