Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve deps differently depending on whether the parent is an addon or an app (inspired by EBM) #358

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

phndiaye
Copy link
Member

What does this PR do?

Resolve deps differently depending on whether the parent is an addon or an app (inspired by EBM)

What are the observable changes?

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

Copy link

linear bot commented Jan 30, 2024

@phndiaye phndiaye merged commit 8aafc17 into master Jan 30, 2024
3 checks passed
@phndiaye phndiaye deleted the pn/vel-2315/fix-dependencies-resolution branch January 30, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants