(experiment) Yarn classic to Yarn 2 w/ nodeLinker

.eslintrc.js

@@ -24,7 +24,6 @@ module.exports = {
     'ember/no-mixins': 'off',
     'ember/no-get': 'off',
     'ember/avoid-leaking-state-in-ember-objects': 'off',
-    'ember/no-global-jquery': 'off',
     'ember/no-classic-classes': 'off',
     'ember/no-classic-components': 'off',
     'ember/require-tagless-components': 'off',

.github/workflows/ci.yml

@@ -10,8 +10,9 @@ on:
 
 env:
   GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-  NODE_VERSION: '14'
+  NODE_VERSION: '16'
   FONTAWESOME_NPM_AUTH_TOKEN: ${{ secrets.FONTAWESOME_NPM_AUTH_TOKEN }}
+  YARN_IGNORE_NODE: 1
 
 jobs:
   test:
@@ -29,7 +30,7 @@ jobs:
           node-version: '${{ env.NODE_VERSION }}'
           cache: 'yarn'
       - name: Install Dependencies
-        run: yarn --prefer-offline --frozen-lockfile
+        run: yarn install
         env:
           GITHUB_TOKEN: ${{ secrets.PAT_TOKEN }}
       - name: Lint
@@ -48,7 +49,7 @@ jobs:
           node-version: '${{ env.NODE_VERSION }}'
           cache: 'yarn'
       - name: Install Dependencies
-        run: yarn --prefer-offline --frozen-lockfile
+        run: yarn install
         env:
           GITHUB_TOKEN: ${{ secrets.PAT_TOKEN }}
       - name: Ember Build
@@ -77,7 +78,7 @@ jobs:
           node-version: '${{ env.NODE_VERSION }}'
           cache: 'yarn'
       - name: Install Dependencies
-        run: yarn --prefer-offline --frozen-lockfile
+        run: yarn install
         env:
           GITHUB_TOKEN: ${{ secrets.PAT_TOKEN }}
       - name: Publish

.gitignore

@@ -19,7 +19,6 @@ storybook-static
 /libpeerconnection.log
 npm-debug.log
 testem.log
-/yarn-error.log
 /package-lock.json
 ember-modules-codemod.*
 
@@ -34,3 +33,13 @@ doc
 # storybook
 preview-head.html
 app/styles/core/fonts/
+
+# yarn
+.pnp.*
+.yarn/*
+!.yarn/patches
+!.yarn/plugins
+!.yarn/releases
+!.yarn/sdks
+!.yarn/versions
+/yarn-error.log

.nvmrc

@@ -0,0 +1 @@
+v16.19.0

.yarnrc.yml

@@ -0,0 +1,15 @@
+nodeLinker: node-modules
+
+npmRegistries:
+  //npm.pkg.github.com:
+    npmAuthToken: "${GITHUB_TOKEN}"
+
+npmScopes:
+  fortawesome:
+    npmAlwaysAuth: true
+    npmAuthToken: "${FONTAWESOME_NPM_AUTH_TOKEN}"
+    npmRegistryServer: "https://npm.fontawesome.com/"
+  upfluence:
+    npmRegistryServer: "https://npm.pkg.github.com"
+
+yarnPath: .yarn/releases/yarn-4.0.2.cjs

addon-test-support/services/uploader.ts

@@ -1,8 +1,9 @@
 import BaseUploader from '@upfluence/oss-components/services/base-uploader';
-import UploaderInterface, {
-  UploadRequest,
-  FileValidator,
-  ValidationResponse
+import {
+  type default as UploaderInterface,
+  type UploadRequest,
+  type FileValidator,
+  type ValidationResponse
 } from '@upfluence/oss-components/types/uploader';
 
 export default class extends BaseUploader implements UploaderInterface {

addon/components/o-s-s/access-panel.hbs

@@ -1,3 +1,4 @@
+{{! @glint-nocheck: not typesafe yet }}
 <div class="oss-access-panel-backdrop" role="button" {{on "click" @onClose}}></div>
 <div class="oss-access-panel-container" {{did-insert this.setupAnimation}} ...attributes>
   {{#if (has-block "header")}}

addon/components/o-s-s/access-panel.ts

@@ -3,16 +3,26 @@ import { tracked } from '@glimmer/tracking';
 import { action } from '@ember/object';
 import { later } from '@ember/runloop';
 
-interface OSSAccessPanelArgs {
-  records: unknown[];
-  initialLoad: boolean;
-  loading?: boolean;
-  onSearch(keyword: string): void;
-  onBottomReached(): void;
-  onClose(): void;
+interface OSSAccessPanelSignature {
+  Args: {
+    records: unknown[];
+    initialLoad: boolean;
+    loading?: boolean;
+    onSearch(keyword: string): void;
+    onBottomReached(): void;
+    onClose(): void;
+  };
+  Blocks: {
+    columns: [];
+    'empty-state': [];
+    header: [];
+    'no-results': [];
+    row: [unknown];
+  };
+  Element: HTMLDivElement;
 }
 
-export default class OSSAccessPanel extends Component<OSSAccessPanelArgs> {
+export default class OSSAccessPanelComponent extends Component<OSSAccessPanelSignature> {
   loadingRows = new Array(12);
   loadingMoreRows = new Array(3);
 
@@ -39,3 +49,10 @@ export default class OSSAccessPanel extends Component<OSSAccessPanelArgs> {
     this.args.onSearch(this.searchKeyword!);
   }
 }
+
+declare module '@glint/environment-ember-loose/registry' {
+  export default interface Registry {
+    'OSS::AccessPanel': typeof OSSAccessPanelComponent;
+    'o-s-s/access-panel': typeof OSSAccessPanelComponent;
+  }
+}

addon/components/o-s-s/alert.stories.js

@@ -1,4 +1,4 @@
-import hbs from 'htmlbars-inline-precompile';
+import { hbs } from 'ember-cli-htmlbars';
 import { action } from '@storybook/addon-actions';
 
 const SkinTypes = ['success', 'info', 'warning', 'error'];

addon/components/o-s-s/alert.ts

@@ -5,16 +5,22 @@ type skinType = 'success' | 'error' | 'warning';
 
 const DEFAULT_SKIN = 'info';
 
-interface OSSAlertArgs {
-  skin?: skinType;
-  title?: string;
-  subtitle?: string;
-  plain?: boolean;
-  closable?: boolean;
-  onClose?(): void;
+interface OSSAlertSignature {
+  Args: {
+    skin?: skinType;
+    title?: string;
+    subtitle?: string;
+    plain?: boolean;
+    closable?: boolean;
+    onClose?(): void;
+  };
+  Blocks: {
+    'extra-content': [];
+  };
+  Element: HTMLDivElement;
 }
 
-export default class OSSAlert extends Component<OSSAlertArgs> {
+export default class OSSAlertComponent extends Component<OSSAlertSignature> {
   private declare _DOMElement: HTMLElement;
 
   get skinClass(): string {
@@ -50,3 +56,10 @@ export default class OSSAlert extends Component<OSSAlertArgs> {
     this._DOMElement?.remove();
   }
 }
+
+declare module '@glint/environment-ember-loose/registry' {
+  export default interface Registry {
+    'OSS::Alert': typeof OSSAlertComponent;
+    'o-s-s/alert': typeof OSSAlertComponent;
+  }
+}

addon/components/o-s-s/array-input.stories.js

@@ -1,4 +1,4 @@
-import hbs from 'htmlbars-inline-precompile';
+import { hbs } from 'ember-cli-htmlbars';
 import { action } from '@storybook/addon-actions';
 
 export default {

addon/components/o-s-s/array-input.ts

@@ -2,23 +2,26 @@ import Component from '@glimmer/component';
 import { action } from '@ember/object';
 import { tracked } from '@glimmer/tracking';
 
-interface OSSArrayInputArgs {
-  values?: string[];
-  keyboardTriggers?: string[];
-  errorMessage?: string;
-  disabled?: boolean;
-  validator?: (value: string) => boolean;
-  onChange?: (values: string[]) => void;
-  placeholder?: string;
+interface OSSArrayInputSignature {
+  Args: {
+    values?: string[];
+    keyboardTriggers?: string[];
+    errorMessage?: string;
+    disabled?: boolean;
+    validator?: (value: string) => boolean;
+    onChange?: (values: string[]) => void;
+    placeholder?: string;
+  };
+  Element: HTMLDivElement;
 }
 
 const DEFAULT_KEYBOARD_TRIGGERS = ['Enter'];
 
-export default class OSSArrayInput extends Component<OSSArrayInputArgs> {
+export default class OSSArrayInputComponent extends Component<OSSArrayInputSignature> {
   @tracked currentValue = '';
   @tracked items: string[] = [];
 
-  constructor(owner: unknown, args: OSSArrayInputArgs) {
+  constructor(owner: unknown, args: OSSArrayInputSignature['Args']) {
     super(owner, args);
     if (this.args.values) {
       this.items = this.args.values;
@@ -97,3 +100,10 @@ export default class OSSArrayInput extends Component<OSSArrayInputArgs> {
     this._onChange();
   }
 }
+
+declare module '@glint/environment-ember-loose/registry' {
+  export default interface Registry {
+    'OSS::ArrayInput': typeof OSSArrayInputComponent;
+    'o-s-s/array-input': typeof OSSArrayInputComponent;
+  }
+}

addon/components/o-s-s/attribute/base.hbs

@@ -1,3 +1,4 @@
+{{! @glint-nocheck: not typesafe yet }}
 <div class="oss-attribute"
      {{on "mouseenter" (fn (mut this.displayCopyBtn) true)}}
      {{on "mouseleave" (fn (mut this.displayCopyBtn) false)}}

addon/components/o-s-s/attribute/base.ts

@@ -1,13 +1,27 @@
 import { isBlank } from '@ember/utils';
 import Component from '@glimmer/component';
 
-interface OSSAttributeBaseArgs {
-  value: string;
-  copyable?: boolean;
+interface OSSAttributeBaseSignature {
+  Args: {
+    value: string;
+    copyable?: boolean;
+  };
+  Blocks: {
+    label: [];
+    value: [];
+  };
+  Element: HTMLDivElement;
 }
 
-export default class OSSAttributeBase extends Component<OSSAttributeBaseArgs> {
+export default class OSSAttributeBaseComponent extends Component<OSSAttributeBaseSignature> {
   get isCopyable(): boolean {
     return (this.args.copyable ?? true) && !isBlank(this.args.value) && this.args.value !== '-';
   }
 }
+
+declare module '@glint/environment-ember-loose/registry' {
+  export default interface Registry {
+    'OSS::Attribute::Base': typeof OSSAttributeBaseComponent;
+    'o-s-s/attribute/base': typeof OSSAttributeBaseComponent;
+  }
+}

addon/components/o-s-s/attribute/country.hbs

@@ -1,3 +1,4 @@
+{{! @glint-nocheck: not typesafe yet }}
 <OSS::Attribute::Base @value={{this.countryName}} data-control-name="attribute-country" ...attributes>
   <:label>
     <span>{{t "oss-components.attribute.country"}}</span>

addon/components/o-s-s/attribute/country.stories.js

@@ -1,4 +1,4 @@
-import hbs from 'htmlbars-inline-precompile';
+import { hbs } from 'ember-cli-htmlbars';
 
 export default {
   title: 'Components/OSS::Attribute::Country',

addon/components/o-s-s/attribute/country.ts

@@ -1,12 +1,15 @@
 import Component from '@glimmer/component';
-import { CountryData, countries } from '@upfluence/oss-components/utils/country-codes';
+import { type CountryData, countries } from '@upfluence/oss-components/utils/country-codes';
 import { tracked } from '@glimmer/tracking';
 
-interface OSSAttributeCountryArgs {
-  countryCode?: string;
+interface OSSAttributeCountrySignature {
+  Args: {
+    countryCode?: string;
+  };
+  Element: HTMLElement;
 }
 
-export default class OSSAttributeCountry extends Component<OSSAttributeCountryArgs> {
+export default class OSSAttributeCountryComponent extends Component<OSSAttributeCountrySignature> {
   @tracked displayCopyBtn: boolean = false;
 
   private countryDictionnary: CountryData[] = countries;
@@ -17,3 +20,10 @@ export default class OSSAttributeCountry extends Component<OSSAttributeCountryAr
     );
   }
 }
+
+declare module '@glint/environment-ember-loose/registry' {
+  export default interface Registry {
+    'OSS::Attribute::Country': typeof OSSAttributeCountryComponent;
+    'o-s-s/attribute/country': typeof OSSAttributeCountryComponent;
+  }
+}

addon/components/o-s-s/attribute/phone-number.hbs

@@ -1,3 +1,4 @@
+{{! @glint-nocheck: not typesafe yet }}
 <OSS::Attribute::Base @value={{this.formattedPhoneNumber}} data-control-name="attribute-phone-number" ...attributes>
   <:label>
     <span>{{t "oss-components.attribute.phone_number"}}</span>

addon/components/o-s-s/attribute/phone-number.stories.js

@@ -1,4 +1,4 @@
-import hbs from 'htmlbars-inline-precompile';
+import { hbs } from 'ember-cli-htmlbars';
 
 export default {
   title: 'Components/OSS::Attribute::PhoneNumber',

addon/components/o-s-s/attribute/phone-number.ts

@@ -1,13 +1,16 @@
 import Component from '@glimmer/component';
-import { CountryData, countries } from '@upfluence/oss-components/utils/country-codes';
+import { type CountryData, countries } from '@upfluence/oss-components/utils/country-codes';
 
-interface OSSAttributePhoneNumberArgs {
-  countryCode?: string;
-  prefix?: string;
-  number?: string;
+interface OSSAttributePhoneNumberSignature {
+  Args: {
+    countryCode?: string;
+    prefix?: string;
+    number?: string;
+  };
+  Element: HTMLElement;
 }
 
-export default class OSSAttributePhoneNumber extends Component<OSSAttributePhoneNumberArgs> {
+export default class OSSAttributePhoneNumberComponent extends Component<OSSAttributePhoneNumberSignature> {
   private countryDictionnary: CountryData[] = countries;
 
   get formattedPhoneNumber(): string {
@@ -22,3 +25,10 @@ export default class OSSAttributePhoneNumber extends Component<OSSAttributePhone
     return this.args.prefix ? `${this.args.prefix} ` : '';
   }
 }
+
+declare module '@glint/environment-ember-loose/registry' {
+  export default interface Registry {
+    'OSS::Attribute::PhoneNumber': typeof OSSAttributePhoneNumberComponent;
+    'o-s-s/attribute/phone-number': typeof OSSAttributePhoneNumberComponent;
+  }
+}

addon/components/o-s-s/attribute/rating.hbs

@@ -1,3 +1,4 @@
+{{! @glint-nocheck: not typesafe yet }}
 <OSS::Attribute::Base class="oss-attribute--no-hover-effect" data-control-name="attribute-rating" ...attributes>
   <:label>
     <span>{{@label}}</span>

addon/components/o-s-s/attribute/rating.stories.js

@@ -1,4 +1,4 @@
-import hbs from 'htmlbars-inline-precompile';
+import { hbs } from 'ember-cli-htmlbars';
 
 export default {
   title: 'Components/OSS::Attribute::Rating',