Fixed upf-stat__label issue #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OwenCoogan
requested review from
phndiaye,
Miexil and
aprentout
and removed request for
a team
Miexil
approved these changes
Dec 14, 2023
| @@ -29,10 +29,10 @@ | |||
| </span> | |||
|
|
|||
| {{#if label}} | |||
| <span class="upf-stat__label"> | |||
| <span class={{concat 'upf-stat__label' (if tooltip '--with-tooltip')}}> | |||
There was a problem hiding this comment.
and maybe
if tooltip "upf-stat__label--with-tooltip" "upf-stat__label"
is clearer, but debatable 🤷 ^^
There was a problem hiding this comment.
or
class="upf-stat__label{{if tooltip "--with-tooltip"}}" 
There was a problem hiding this comment.
Fixed for your solution @Miexil
upfluence-bot
added
reviewed/ready-to-merge
reviewed/needs-work
and removed
reviewed/needs-review
reviewed/ready-to-merge
labels
aprentout
approved these changes
Dec 14, 2023
| @@ -29,10 +29,10 @@ | |||
| </span> | |||
|
|
|||
| {{#if label}} | |||
| <span class="upf-stat__label"> | |||
| <span class={{concat 'upf-stat__label' (if tooltip '--with-tooltip')}}> | |||
There was a problem hiding this comment.
or
class="upf-stat__label{{if tooltip "--with-tooltip"}}"
app/styles/base/_stats.less
Outdated
| display: flex; | ||
| gap: var(--spacing-px-6); | ||
| align-items: center; | ||
| color: @color-text-light; |
There was a problem hiding this comment.
Nit: Replace @color-text-light with var(--color-gray-500)
phndiaye
approved these changes
Dec 14, 2023
upfluence-bot
added
reviewed/needs-work
and removed
reviewed/needs-review
reviewed/needs-work
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes the display of upf stat label
Related to: #
https://linear.app/upfluence/issue/ENG-2079/creator-media-stats-have-bad-alignment-in-sidepanel
What are the observable changes?
Fixes display issues that emerged with this commit. A condition is added in order to switch classes when a tooltip is present.
Good PR checklist