Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pnpm 8 to 10 & CI node version 20 #223

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

JulienVannier66
Copy link
Contributor

What does this PR do?

  • Upgrade pnpm version from 8 to 10
  • upgrade CI node version to 20

What are the observable changes?

πŸ§‘β€πŸ’» Developer Heads Up

⚑ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

@JulienVannier66 JulienVannier66 self-assigned this Jan 13, 2025
@JulienVannier66 JulienVannier66 requested review from phndiaye and a team as code owners January 13, 2025 14:40
@JulienVannier66 JulienVannier66 requested review from OwenCoogan and aprentout and removed request for a team January 13, 2025 14:40
Copy link

linear bot commented Jan 13, 2025

@JulienVannier66 JulienVannier66 force-pushed the jv/vel-4622/pnpm-8-to-10 branch from 8671e98 to a5b61c8 Compare January 14, 2025 10:51
@phndiaye phndiaye merged commit aadfe5c into master Jan 14, 2025
6 checks passed
@phndiaye phndiaye deleted the jv/vel-4622/pnpm-8-to-10 branch January 14, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants