Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hypertable v2: add support for empty_state_message #217

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

phndiaye
Copy link
Member

What does this PR do?

hypertable v2: add support for empty_state_message

What are the observable changes?

🧑‍💻 Developer Heads Up

⚡ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

Additional Notes

@phndiaye phndiaye requested a review from a team as a code owner November 21, 2024 14:28
@phndiaye phndiaye requested review from Xegushu, aprentout and nathalieArnoux and removed request for a team November 21, 2024 14:28
@phndiaye phndiaye merged commit 3167c4b into pn/vel-4194 Nov 22, 2024
3 checks passed
@phndiaye phndiaye deleted the pn/vel-4195 branch November 22, 2024 16:58
phndiaye added a commit that referenced this pull request Dec 16, 2024
* hypertable v2: add support for empty_state_message

* add more test scenarios for rows and fix tests

* hyper-table-v2/filtering-renderers/numeric: add multiplier option, allows for extension in money-type columns
phndiaye added a commit that referenced this pull request Dec 19, 2024
* hypertable v2: add support for empty_state_message

* add more test scenarios for rows and fix tests

* hyper-table-v2/filtering-renderers/numeric: add multiplier option, allows for extension in money-type columns
phndiaye added a commit that referenced this pull request Dec 27, 2024
* hypertable v2: add support for empty_state_message

* add more test scenarios for rows and fix tests

* hyper-table-v2/filtering-renderers/numeric: add multiplier option, allows for extension in money-type columns
phndiaye added a commit that referenced this pull request Dec 31, 2024
…e extended (#216)

* hyper-table-v2/filtering-renderers/date: allow moving option key to be extended

* hypertable v2: add support for empty_state_message (#217)

* hypertable v2: add support for empty_state_message

* add more test scenarios for rows and fix tests

* hyper-table-v2/filtering-renderers/numeric: add multiplier option, allows for extension in money-type columns

* feat(hyper-table-v2/filtering-renderers/common/search): add support for passing a filterKey

* fix pr feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants