Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure content validation on numeric filters fields #210

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Ensure content validation on numeric filters fields #210

merged 5 commits into from
Aug 5, 2024

Conversation

phndiaye
Copy link
Member

@phndiaye phndiaye commented Aug 1, 2024

What does this PR do?

  • Ensure content validation on numeric filters fields
  • Update the UI components used for:
    • Ordering: legacy radio-button groups -> OSS::ToggleButtons
    • Existence filteres: legacy radio-button -> OSS::RadioButton

What are the observable changes?

🧑‍💻 Developer Heads Up

⚡ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

Additional Notes

@phndiaye phndiaye requested a review from a team as a code owner August 1, 2024 08:24
@phndiaye phndiaye requested review from JulienVannier66, aprentout and nathalieArnoux and removed request for a team August 1, 2024 08:24
@linear Linear
Copy link

linear bot commented Aug 1, 2024

VEL-3586 [Hypertable] Allow only integer in search field of integer column

@phndiaye phndiaye self-assigned this Aug 1, 2024
@OwenCoogan OwenCoogan self-requested a review August 1, 2024 12:12
@phndiaye phndiaye merged commit e380bda into master Aug 5, 2024
3 checks passed
@phndiaye phndiaye deleted the pn/vel-3586 branch August 5, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprentout aprentout aprentout approved these changes

@JulienVannier66 JulienVannier66 JulienVannier66 approved these changes

@OwenCoogan OwenCoogan OwenCoogan approved these changes

@nathalieArnoux nathalieArnoux Awaiting requested review from nathalieArnoux nathalieArnoux is a code owner automatically assigned from upfluence/frontend

Assignees

@phndiaye phndiaye

Labels
reviewed/needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@phndiaye @OwenCoogan @JulienVannier66 @aprentout @upfluence-bot