Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter renderer: Update removeColumn action #206

Merged
merged 1 commit into from
May 30, 2024
Merged

Filter renderer: Update removeColumn action #206

merged 1 commit into from
May 30, 2024

Conversation

aprentout
Copy link
Contributor

What does this PR do?

Related to : #DRA-655

What are the observable changes?

πŸ§‘β€πŸ’» Developer Heads Up

⚑ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

Additional Notes

@aprentout aprentout self-assigned this May 28, 2024
@aprentout aprentout requested review from phndiaye and a team as code owners May 28, 2024 12:32
@aprentout aprentout requested review from Miexil and OwenCoogan and removed request for a team May 28, 2024 12:32
Copy link

linear bot commented May 28, 2024

@aprentout aprentout merged commit 69d38c4 into master May 30, 2024
3 checks passed
@aprentout aprentout deleted the ap/dra-655 branch May 30, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants