HypertableV2: Close the filter when scrolling inside the table #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miexil
requested review from
OwenCoogan and
aprentout
and removed request for
a team
Miexil
commented
Apr 26, 2024
Comment on lines
+165
to
+180
| private _scrollToEnd(table: HTMLElement): void { | ||
| table.scrollLeft = table.scrollWidth; | ||
| } | ||
|
|
||
| private _setupInnerTableElement(table: HTMLElement): void { | ||
| table.addEventListener('scroll', () => { | ||
| this.args.handler.destroyTetherInstance(); | ||
| if (table.scrollLeft === table.scrollWidth - table.clientWidth) { | ||
| this.scrollableTable = false; | ||
| } else if (!this.scrollableTable) { | ||
| this.scrollableTable = true; | ||
| } | ||
| }); | ||
|
|
||
| this.computeScrollableTable(); | ||
| } |
There was a problem hiding this comment.
Getting rid of warnings here by doing this.
Warning was :
Do not use anonymous functions as arguments to
debounce,once, andscheduleOnce
JulienVannier66
approved these changes
Apr 26, 2024
aprentout
approved these changes
Apr 26, 2024
phndiaye
approved these changes
Apr 26, 2024
OwenCoogan
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Close the filter when scrolling inside the table
Good PR checklist