Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset selection when resetting all columns #203

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Reset selection when resetting all columns #203

merged 1 commit into from
Apr 15, 2024

Conversation

phndiaye
Copy link
Member

What does this PR do?

Reset selection when resetting all columns

What are the observable changes?

πŸ§‘β€πŸ’» Developer Heads Up

⚑ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

Additional Notes

@phndiaye phndiaye requested a review from a team as a code owner April 15, 2024 12:36
@phndiaye phndiaye requested review from OwenCoogan, JulienVannier66 and aprentout and removed request for a team April 15, 2024 12:36
Copy link

linear bot commented Apr 15, 2024

@phndiaye phndiaye merged commit 888947c into master Apr 15, 2024
3 checks passed
@phndiaye phndiaye deleted the pn/vel-1936 branch April 15, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants