Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSelect: Remove dependency & replace usage #202

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

aprentout
Copy link
Contributor

What does this PR do?

Related to : #VEL-2360

What are the observable changes?

πŸ§‘β€πŸ’» Developer Heads Up

⚑ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

Additional Notes

@aprentout aprentout self-assigned this Mar 6, 2024
@aprentout aprentout requested review from phndiaye and a team as code owners March 6, 2024 10:55
@aprentout aprentout requested review from Miexil and JulienVannier66 and removed request for a team March 6, 2024 10:55
Copy link

linear bot commented Mar 6, 2024

@aprentout aprentout merged commit cc2f9d7 into master Mar 8, 2024
3 checks passed
@aprentout aprentout deleted the ap/vel-2360 branch March 8, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants