Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember-intl: Migrate to v6.4 #200

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Ember-intl: Migrate to v6.4 #200

merged 2 commits into from
Feb 12, 2024

Conversation

aprentout
Copy link
Contributor

What does this PR do?

Related to : #VEL-2179

What are the observable changes?

πŸ§‘β€πŸ’» Developer Heads Up

⚑ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

Additional Notes

@aprentout aprentout requested review from phndiaye and a team as code owners January 31, 2024 16:10
@aprentout aprentout requested review from OwenCoogan and JulienVannier66 and removed request for a team January 31, 2024 16:10
Copy link

linear bot commented Jan 31, 2024

@aprentout aprentout self-assigned this Jan 31, 2024
@aprentout aprentout marked this pull request as draft January 31, 2024 16:15
@aprentout aprentout marked this pull request as ready for review February 6, 2024 08:10
tests/dummy/app/routes/application.ts Outdated Show resolved Hide resolved
@aprentout aprentout merged commit 95233a0 into master Feb 12, 2024
3 checks passed
@aprentout aprentout deleted the ap/vel-2179 branch February 12, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants