Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration for pnpm #199

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Migration for pnpm #199

merged 2 commits into from
Jan 31, 2024

Conversation

JulienVannier66
Copy link
Contributor

@JulienVannier66 JulienVannier66 commented Jan 29, 2024

What does this PR do?

Migration for pnpm

Related to : https://linear.app/upfluence/issue/VEL-2320/migrate-hypertable-to-pnpm

What are the observable changes?

yarn
no-cache: 106.51s
cache: N/A

pnpm
no-cache: 16.9s (-~84%)
cache: N/A

🧑‍💻 Developer Heads Up

⚡ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

@JulienVannier66 JulienVannier66 self-assigned this Jan 29, 2024
@JulienVannier66 JulienVannier66 requested review from phndiaye and a team as code owners January 29, 2024 14:25
@JulienVannier66 JulienVannier66 requested review from Miexil and OwenCoogan and removed request for a team January 29, 2024 14:25
Copy link

linear bot commented Jan 29, 2024

Copy link
Member

@Miexil Miexil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about some of the Makefile changes but other than that, lgtm

Makefile Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@phndiaye phndiaye merged commit 68d74e1 into master Jan 31, 2024
4 checks passed
@phndiaye phndiaye deleted the jv/vel-2320/pnpm-migration branch January 31, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants