Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter first column offset #191

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

JulienVannier66
Copy link
Contributor

What does this PR do?

Update filter first column offset

Related to : https://linear.app/upfluence/issue/ENG-1209/off-screen-filter-menu-in-table-with-only-2-columns

What are the observable changes?

Peek 2023-11-15 17-27

🧑‍💻 Developer Heads Up

⚡ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

@JulienVannier66 JulienVannier66 self-assigned this Nov 15, 2023
@JulienVannier66 JulienVannier66 requested review from phndiaye and a team as code owners November 15, 2023 16:28
@JulienVannier66 JulienVannier66 requested review from OwenCoogan and aprentout and removed request for a team November 15, 2023 16:28
Copy link

linear bot commented Nov 15, 2023

ENG-1209 Off-screen filter menu in table with only 2 columns

Description

When having only 2 columns in a table view and clicking the filter button on the second field, the filter menu will appear partially off-screen.

Note: only affects Workflow + IRM tables.

To Reproduce

Steps to reproduce the behavior:

  1. Go to IRM

  2. Create a new view

  3. Remove all available filters until only "Media name" is available

  4. Select a secondary field

    Example: Country field

  5. Click on the filter button for the Country column

  6. Notice that the filter menu will appear a bit off-screen:

    image.png

  7. When trying to scroll horizontally however, you need to click on the bottom scroll bar, and that will make the filter menu dissappear every time

Expected behavior

The filter menu should always be fully visible.

Screenshots (if relevant)

Included in sections above.

@JulienVannier66 JulienVannier66 merged commit 5af8d09 into master Nov 16, 2023
3 checks passed
@JulienVannier66 JulienVannier66 deleted the jv/eng-1209/filter-first-column-offset branch November 16, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants