Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drag icon overlapping the filter trigger #188

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

phndiaye
Copy link
Member

@phndiaye phndiaye commented Nov 2, 2023

What does this PR do?

Fix drag icon overlapping the filter trigger

What are the observable changes?

🧑‍💻 Developer Heads Up

⚡ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

Additional Notes

@phndiaye phndiaye requested a review from a team as a code owner November 2, 2023 08:47
@phndiaye phndiaye requested review from OwenCoogan, JulienVannier66 and aprentout and removed request for a team November 2, 2023 08:47
Copy link

linear bot commented Nov 2, 2023

ENG-1445 IRM filter icon is difficult to click

Description

Problem reported multiple times by Alexis and all the users doesnt have the same behavior here. When you hover the filter icon, for some ppl (i.e. Alexis), you need to be extremely precise to be able to trigger the filter menu opening. This lead to frustration.

Capture d’écran 2023-10-06 à 15.32.16.png

To Reproduce

Steps to reproduce the behavior:

  1. Go to IRM
  2. Hover the filter icon
  3. See error

Expected behavior

  1. We must understand why this happen on Alexis's side and not on everyone env
  2. We must have a solution to generalize the behavior that is more "flexible" and allow user to click a bit apart from the icon itself

@phndiaye phndiaye merged commit a0c0dff into master Nov 2, 2023
3 checks passed
@phndiaye phndiaye deleted the pn/eng-1445 branch November 2, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants