Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorator: Required brand, call super before model when brand match requirement #10

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

aprentout
Copy link
Contributor

@aprentout aprentout commented Sep 2, 2024

What does this PR do?

Currently, the use of required-brand decorator prevent the trigger of beforeModel() in route. The objective is to allow this usage when brand match the requirements.

Related to: #

What are the observable changes?

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Properly labeled

@aprentout aprentout merged commit 3c0cf3e into main Sep 4, 2024
1 check passed
@Miexil Miexil deleted the fix/required_brand_decorator branch September 4, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants