Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

Fix private method called for #<Logger #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

g3d
Copy link
Contributor

@g3d g3d commented Sep 24, 2013

User logger.info to prevent NoMethodError: private method `puts' called for #<Logger

@g3d
Copy link
Contributor Author

g3d commented Sep 30, 2013

Can you add any info about what improvement you need in this pull request to merge it?

@troelskn
Copy link
Contributor

troelskn commented Oct 2, 2013

Yes, sorry for the lack of response. logger - despite its ill-confounded name - is actually an IO and not a Logger. Or at least, that's how it has been used so far. I agree that it would be more meaningful to take a Logger proper, but to conserve BC, a change should work on both types. I imagine this could be done by modifying def self.logger=. If you'll make the change and rebase on top of master, I'll merge it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants