Reduce permissions and fix version in AWS Actions #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tverghis I edited cpi-count-test, does it look ok with these? |
tverghis
approved these changes
Jan 23, 2025
use version number (rather than hash) to select spot-capable ec2-github-runner version. Credit @tverghis for suggesting Co-authored-by: Tarun Verghis <[email protected]>
|
Thanks again @tverghis ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimented with removing some of the
permissionsand was able to remove two in the AWS template and in the CPI AWS tests.Fixed the version of ec2-github-runner to the new version supporting spot
Verified both workflows work, and use spot instances (on the AWS console)