Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/new auth flow fix #1122

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Feat/new auth flow fix #1122

wants to merge 6 commits into from

Conversation

yokwejuste
Copy link
Collaborator

Summary

This PR is an implementation of the new auth flow.

Copy of #1081

@yokwejuste yokwejuste marked this pull request as ready for review March 2, 2024 05:02
Copy link

github-actions bot commented Mar 2, 2024

pre-commit checks failed ❌❌❌
make sure you have pre-commit set up locally (see the README.md for instructions).
If you have set up pre-commit locally, you may need to undo this commit and
run "pre-commit" locally to see what the errors are.

Copy link

github-actions bot commented Mar 2, 2024

pre-commit checks failed ❌❌❌
make sure you have pre-commit set up locally (see the README.md for instructions).
If you have set up pre-commit locally, you may need to undo this commit and
run "pre-commit" locally to see what the errors are.

Copy link

github-actions bot commented Mar 5, 2024

pre-commit checks failed ❌❌❌
make sure you have pre-commit set up locally (see the README.md for instructions).
If you have set up pre-commit locally, you may need to undo this commit and
run "pre-commit" locally to see what the errors are.

Copy link

github-actions bot commented Mar 5, 2024

pre-commit checks failed ❌❌❌
make sure you have pre-commit set up locally (see the README.md for instructions).
If you have set up pre-commit locally, you may need to undo this commit and
run "pre-commit" locally to see what the errors are.

@NdibeRaymond
Copy link
Collaborator

You should also rebase, and fix the failing pre-commit changes. I posted the link to a video I made on zulip, about how to go about that

@NdibeRaymond
Copy link
Collaborator

part of that failing pre-commit test is the little test we have on the backend for user creation. You need to update the test to make sure it passes. Right now it's failing, which is a pointer that the PR is failing. This looks to be the same PR that was reverted right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants