Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): Implement Email #1085

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

(feat): Implement Email #1085

wants to merge 6 commits into from

Conversation

brrkrmn
Copy link
Collaborator

@brrkrmn brrkrmn commented Jan 10, 2024

Summary

Tasks and new email templates according to the styles here are added to the backend

Closing #1039

Changes

  • email-base.html has the common elements of the email (logos, footer)
  • child templates include the dynamic content. Password reset and email verification email templates are located based on Rest Auth documentation.
  • Media are uploaded to the static folder

To do

  • When new badge system is implemented, badge images should be uploaded to and used from static
  • Sendgrid api key and subscription settings should be added
  • New design should be implemented for the comment email template

Template Previews

Account Activation Mail
New Follower Mail
Bookmark Mail

Problems with mobile clients

Gmail App on any device, Gmail on Chrome

  • --Solved-- Not recognizing html symbols (copyright and emojis)
  • Not rendering images --> predicted to be solved on prod

Problems with desktop clients

Outlook (2019, 2021) on Windows, OL Office 365 on Windows

  • Adds black background to images in light mode
  • Adds white background to images in dark mode
  • Border radius is not recognized
  • Image sizes are changed (max-height and object-fit not recognized)

Problems with web clients

Yahoo! Mail and AOL Mail on web

  • not recognizing object-fit

@brrkrmn brrkrmn linked an issue Jan 10, 2024 that may be closed by this pull request
@brrkrmn brrkrmn marked this pull request as ready for review January 11, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement email system with new templates
1 participant